Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61288 )
Change subject: Add mediatek_i2c_spi interface ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS1:
Will address in a follow-up change as needed
This is very unsettling. We already have some similar drivers in the tree. While they don't have open promises like this (I only remember talking about missing man-page documentation so far), they seem to be only reviewed by chromium flashrom standards, which is a different project where things are allowed that are considered completely wrong here.
Adding more drivers like this only increases the chances that somebody will use them as a role model in the future. Eventually this propably creates three times the workload for everyone involved (write drivers for downstream, review that, discuss, maintain code that shouldn't be there, re-write drivers for upstream, review, ...). It basically defeats the purpose of upstreaming (unless the purpose is to have somebody else maintain the code).
For other drivers I fear that in two years or so, nobody will remember for what board they were written (and that's critical when drivers contain board specific code (which is not allowed anyway)). Then we would have reviewed and maintained them for naught. It might become easier to reverse engineer proprietary vendor tools than to figure out how to make the open-source drivers work :-(