Change in flashrom[master]: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25099 )

Change subject: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW.
......................................................................

Patch Set 1:

(8 comments)

https://review.coreboot.org/#/c/25099/1/flashchips.c
File flashchips.c:

https://review.coreboot.org/#/c/25099/1/flashchips.c@1531
PS1, Line 1531: 		/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
Can't find OTP in datasheet.

https://review.coreboot.org/#/c/25099/1/flashchips.c@1532
PS1, Line 1532: FEATURE_OTP
...

https://review.coreboot.org/#/c/25099/1/flashchips.c@1532
PS1, Line 1532: WREN
Just noticed the notion of EWSR as "Write Enable for Volatile
Status Register": If EWSR is used instead of WREN before a write
to the status register, the changes will be volatile. That would
suit flashrom better, IMHO.

David, I've seen this is supported by other chips as well (e.g.
W25Q128.V). But we set FEATURE_WRSR_WREN there. Any clues?

https://review.coreboot.org/#/c/25099/1/flashchips.c@1555
PS1, Line 1555: 		.printlock	= spi_prettyprint_status_register_at25df,
              : 		.unlock		= spi_disable_blockprotect_at2x_global_unprotect,
SF family uses very different status register layout

https://review.coreboot.org/#/c/25099/1/flashchips.c@1559
PS1, Line 1559: 2.3-3.6V
can't find 2.3V in the datasheet

https://review.coreboot.org/#/c/25099/1/flashchips.c@15075
PS1, Line 15075: 256B
3*256B ?

https://review.coreboot.org/#/c/25099/1/flashchips.c@15076
PS1, Line 15076: FEATURE_WRSR_WREN
hmmm, same EWSR story as above.

https://review.coreboot.org/#/c/25099/1/flashchips.c@15103
PS1, Line 15103: 1700
1.65V?