Change in flashrom[master]: tests: Guard sys/io.h the same as in hwaccess_x86_io.h - flashrom-gerrit

23 Jun 2021


      Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55741 )
Change subject: tests: Guard sys/io.h the same as in hwaccess_x86_io.h
......................................................................
Patch Set 3:
(1 comment)
File hwaccess_x86_io_unittest.h:
https://review.coreboot.org/c/flashrom/+/55741/comment/20643efc_d06c1f05 
PS2, Line 32:
...
I moved these guards above, as you suggested. […]
One is a test for x86'ism and the other two are testing if the OS is Linux or glibc gnu userspace.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55741
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f2f0408be7c00f954b899031b52b2b97ef19ca3
Gerrit-Change-Number: 55741
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Wed, 23 Jun 2021 01:24:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment