Change in flashrom[master]: [RFC][WIP] Makefile: use directory for object files - flashrom-gerrit

19 Jan 2022


      Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61034 )
Change subject: [RFC][WIP] Makefile: use directory for object files
......................................................................
Patch Set 2:
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61034/comment/38965c51_98dad225 
PS1, Line 925: _create_OBJPATH
...
Doesn't this trigger a re-build of everything every time?
Done
https://review.coreboot.org/c/flashrom/+/61034/comment/49bdbe9c_309a71ef 
PS1, Line 1093: -include $(OBJPATH)/$(OBJS:.o=.d)
...
This needs `$(addprefix )`. […]
OBJS := $(addprefix $(OBJPATH)/,$(OBJS))
I'll work on this.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/61034
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id0b5eea0b4c941f5af37c0d27dcc95c0bb45461f
Gerrit-Change-Number: 61034
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 19 Jan 2022 17:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment