Attention is currently required from: Balázs Vinarz, Keith Hui, Nico Huber.
Anastasia Klimchuk has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/23053?usp=email )
Change subject: Fwd: Software info for Willem/EZOflash ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: I did a quick look, I have few things, tell me what you think:
1) You need to add a manpage entry for ezo into `doc/classic_cli_manpage.rst`. From that file, manpage is generated and also a webpage https://flashrom.org/classic_cli_manpage.html . We have a doc https://flashrom.org/how_to_add_docs.html but if this is a trouble I can help: you can write a text and I can generate docs and check formatting etc.
2) Add your copyright, in the beginning of the file. You made significant changes.
3) Update commit message, make a title "Add programmer for <...>" and then write a commit description of the ezo programmer. You can add historical links (to patchwork or mailing list) to commit description, just check that links are still working.
4) Remove global state (lpt_iobase). We had a big effort some time ago to remove global state from programmers, and most of them were done (not all though). For example this is the patch for rayer_spi https://review.coreboot.org/c/flashrom/+/54998 . If you agree, I can help with this, I did remove lots of global state from programmers.
5) Fix build errors. I think I can help with this too, but tell me if you want?
-
Anastasia Klimchuk (Code Review)