Attention is currently required from: Nico Huber, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59280 )
Change subject: pcidev: Move pci_dev_find() from internal to canonical place
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59280/comment/140d2fbd_9ba0e0dc
PS5, Line 10: sudo ./flashrom -p internal -r /tmp/bios
The same comment as in the previous patch: if you could add info what environment the command was performed, would be great.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie21f87699481a84398ca4450b3f03548f0528191
Gerrit-Change-Number: 59280
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Fri, 18 Mar 2022 03:46:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment