Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60110 )
Change subject: hwaccess: move x86 port I/O related code into own files ......................................................................
Patch Set 4:
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/60110/comment/35ad35aa_e532052c PS4, Line 783: ifneq ($(NEED_RAW_ACCESS), ) : # Raw memory, MSR or PCI port I/O access. : FEATURE_CFLAGS += -D'NEED_RAW_ACCESS=1' -D'__FLASHROM_HAVE_OUTB__=1' : PROGRAMMER_OBJS += physmap.o hwaccess.o hwaccess_x86_io.o Mostly curiosity: what is the way to build with NEED_RAW_ACCESS empty? Would that be disabling all the drivers that need raw access? Running `make` by default will have drivers that need raw access, which gives one (positive) branch of ifneq condition, that's what I am thinking.
File tests/hwaccess_x86_io_unittest.h:
https://review.coreboot.org/c/flashrom/+/60110/comment/6e74bef6_329c2b20 PS4, Line 33: int rget_io_perms(void); If you could move it below all defines and includes (right above iopl)? thanks!