Attention is currently required from: Nico Huber, Savva.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63345 )
Change subject: flashchips: Add AT45DB641E
......................................................................
Patch Set 1:
(1 comment)
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/63345/comment/1a75021c_eafaf6fc
PS1, Line 196: #define ATMEL_AT45DB642D 0x280000
: #define ATMEL_AT45DB641E 0x280001
Hmmm, how exactly does this work? `probe_spi_at45db()` calls `probe_spi_rdid()`, which only reads 3 bytes (one byte for vendor ID, two bytes for device ID).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I56843b02bee74918a5131326627941ea82003f1f
Gerrit-Change-Number: 63345
Gerrit-PatchSet: 1
Gerrit-Owner: Savva
savvamtr@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Savva
savvamtr@gmail.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 15:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment