[S] Change in flashrom[1.3.x]: flashchips.c: remove WREN from GD25Q256D enter 4BA sequence

[Anastasia Klimchuk (Code Review)]

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/70323 )

Change subject: flashchips.c: remove WREN from GD25Q256D enter 4BA sequence
......................................................................

flashchips.c: remove WREN from GD25Q256D enter 4BA sequence

As noted in a comment on
`commit 86fc9cf7ab221bc54ef6f10252e296fc2d7a22d2`, the GD25Q256D
datasheet indicates that the chip does not require a WREN command to
enter 4BA mode.

Testing has confirmed that a WREN command is not required, so change the
flashchip feature flags from FEATURE_4BA_WREN to FEATURE_4BA.

Ticket: https://ticket.coreboot.org/issues/356

BUG=none
BRANCH=none
TEST=read/write/erase/verify GD25Q256D flash with FT2232H programmer
TEST=called spi_enter_exit_4ba(true), dumped registers, checked ADS=1.

Original-Signed-off-by: Nikolai Artemiev 
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/70342
Original-Tested-by: build bot (Jenkins) 
Original-Reviewed-by: Anastasia Klimchuk 
Original-Reviewed-by: Nico Huber 
(cherry picked from commit 7f3c3f5c4807f4f3c0c2de405189e86b3f8d77a3)

Change-Id: I96e48933f33c52c0d10a0d4cb7f7e07c1fceab99
Signed-off-by: Evan Benn 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/70323
Tested-by: build bot (Jenkins) 
Reviewed-by: Anastasia Klimchuk 
Reviewed-by: David Hendricks 
Reviewed-by: Angel Pons 
---
M flashchips.c
1 file changed, 38 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  David Hendricks: Looks good to me, approved
  Angel Pons: Looks good to me, approved
  Anastasia Klimchuk: Looks good to me, approved

diff --git a/flashchips.c b/flashchips.c
index 76f3fbb..9d5b22c 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -6753,7 +6753,7 @@
    	.model_id	= GIGADEVICE_GD25Q256D,
    	.total_size	= 32768,
    	.page_size	= 256,
-		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_WREN |
+		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA |
    			  FEATURE_WRSR_EXT2 | FEATURE_WRSR2 | FEATURE_WRSR3,
    	.tested		= TEST_OK_PREWB,
    	.probe		= PROBE_SPI_RDID,