Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Eric Park has posted comments on this change by Eric Park. ( https://review.coreboot.org/c/flashrom/+/86990?usp=email )
Change subject: flashchips: Add XMC XM25QH64A
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Patchset:
PS7:
Finished testing, ready for final review/merge
File flashchips/xmc.c:
https://review.coreboot.org/c/flashrom/+/86990/comment/62c61e02_2e23a512?usp... :
PS6, Line 337: TEST_OK_PREW
I can test wiping the chip that I have and rewriting with the bin I pulled off originally; can we le […]
I've finished testing wiping/writing the chip and it works flawlessly. Verified by wiping, pulling an image, verifying it's empty, then rewriting the original firmware bin file and making sure the appliance still works. Please let me know if there is anything else to modify before merging!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/86990?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b
Gerrit-Change-Number: 86990
Gerrit-PatchSet: 7
Gerrit-Owner: Eric Park
me@ericswpark.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Eric Park
me@ericswpark.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Wed, 26 Mar 2025 16:25:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Eric Park
me@ericswpark.com