Change in flashrom[master]: flashrom.c: Move do_*() helpers into cli_classic.c - flashrom-gerrit

24 Jan 2022


      Attention is currently required from: Nico Huber, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60070 )
Change subject: flashrom.c: Move do_*() helpers into cli_classic.c
......................................................................
Patch Set 5:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/60070/comment/eb5d6f99_6d2dac9d 
PS2, Line 156: 
             : static
...
I like the idea of cli_common because cli_classic is already really large :\ I am not entirely sure  […]
Yes the symbols would not be static any more and there is only one call site so it probably doesn't actually make sense.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/60070
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If1112155e2421e0178fd73f847cbb80868387433
Gerrit-Change-Number: 60070
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Thomas Heijligen src@posteo.de
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 24 Jan 2022 03:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment