Attention is currently required from: Nico Huber, Rizwan Qureshi, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 )
Change subject: ichspi: Add Alder Lake support
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS12:
Sorry I think I didn't write well. We are saying the same thing.
Saying it's hard to predict the result of future work.
Exactly this!
As for the enum, sorry I meant to say enum values. That is to say, a enum value that represents multiple chipsets that are the same and folding up the individual 500 and 600 together as an example.
Also like you said, I wanted to be consistent with the current approach which is what I meant by not being half-baked that is to say, doing something new but only for subset of chipsets. For example https://review.coreboot.org/c/flashrom/+/62580 could be needed and probably some other consistency cleanups? Subrata and I plan to discuss to have a audit over things to look for incomplete cases.
Resolved?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62251
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf
Gerrit-Change-Number: 62251
Gerrit-PatchSet: 13
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 04 Mar 2022 01:25:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment