Change in flashrom[master]: chipset_enable: Fix recent -Wmissing-field-initializer trouble
Hello Jacob Garber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/34551
to review the following change.
Change subject: chipset_enable: Fix recent -Wmissing-field-initializer trouble ......................................................................
chipset_enable: Fix recent -Wmissing-field-initializer trouble
Change-Id: Idb2ec4a767bdc8fdfab6a78b6448e76ea3388a32 Signed-off-by: Nico Huber nico.h@gmx.de --- M chipset_enable.c 1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/34551/1
diff --git a/chipset_enable.c b/chipset_enable.c index 44e3e22..7fb06ee 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -631,13 +631,13 @@ }; static const struct boot_straps boot_straps_EP80579[] = { { "SPI", BUS_SPI }, - { "reserved" }, - { "reserved" }, + { "reserved", 0 }, + { "reserved", 0 }, { "LPC", BUS_LPC | BUS_FWH } }; static const struct boot_straps boot_straps_ich7_nm10[] = - { { "reserved" }, + { { "reserved", 0 }, { "SPI", BUS_SPI }, - { "PCI" }, + { "PCI", 0 }, { "LPC", BUS_LPC | BUS_FWH } }; static const struct boot_straps boot_straps_tunnel_creek[] = { { "SPI", BUS_SPI }, @@ -645,29 +645,29 @@ static const struct boot_straps boot_straps_ich8910[] = { { "SPI", BUS_SPI }, { "SPI", BUS_SPI }, - { "PCI" }, + { "PCI", 0 }, { "LPC", BUS_LPC | BUS_FWH } }; static const struct boot_straps boot_straps_pch567[] = { { "LPC", BUS_LPC | BUS_FWH }, - { "reserved" }, - { "PCI" }, + { "reserved", 0 }, + { "PCI", 0 }, { "SPI", BUS_SPI } }; static const struct boot_straps boot_straps_pch89_baytrail[] = { { "LPC", BUS_LPC | BUS_FWH }, - { "reserved" }, - { "reserved" }, + { "reserved", 0 }, + { "reserved", 0 }, { "SPI", BUS_SPI } }; static const struct boot_straps boot_straps_pch8_lp[] = { { "SPI", BUS_SPI }, { "LPC", BUS_LPC | BUS_FWH } }; static const struct boot_straps boot_straps_apl[] = { { "SPI", BUS_SPI }, - { "reserved" } }; + { "reserved", 0 } }; static const struct boot_straps boot_straps_unknown[] = - { { "unknown" }, - { "unknown" }, - { "unknown" }, - { "unknown" } }; + { { "unknown", 0 }, + { "unknown", 0 }, + { "unknown", 0 }, + { "unknown", 0 } };
const struct boot_straps *boot_straps; switch (ich_generation) {
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34551 )
Change subject: chipset_enable: Fix recent -Wmissing-field-initializer trouble ......................................................................
Patch Set 3: Code-Review+2
All these values are being implicitly initialized to 0 anyway, so I don't see a problem in making it explicit.
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34551 )
Change subject: chipset_enable: Fix recent -Wmissing-field-initializer trouble ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/34551/3/chipset_enable.c File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/34551/3/chipset_enable.c@634 PS3, Line 634: 0 Err, rather, should these be BUS_NONE (which is 0 anyway)?
Hello Jacob Garber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/34551
to look at the new patch set (#4).
Change subject: chipset_enable: Fix recent -Wmissing-field-initializer trouble ......................................................................
chipset_enable: Fix recent -Wmissing-field-initializer trouble
Change-Id: Idb2ec4a767bdc8fdfab6a78b6448e76ea3388a32 Signed-off-by: Nico Huber nico.h@gmx.de --- M chipset_enable.c 1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/34551/4
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34551 )
Change subject: chipset_enable: Fix recent -Wmissing-field-initializer trouble ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/flashrom/+/34551/3/chipset_enable.c File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/34551/3/chipset_enable.c@634 PS3, Line 634: 0
Err, rather, should these be BUS_NONE (which is 0 anyway)?
Ack
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34551 )
Change subject: chipset_enable: Fix recent -Wmissing-field-initializer trouble ......................................................................
Patch Set 4: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34551 )
Change subject: chipset_enable: Fix recent -Wmissing-field-initializer trouble ......................................................................
chipset_enable: Fix recent -Wmissing-field-initializer trouble
Change-Id: Idb2ec4a767bdc8fdfab6a78b6448e76ea3388a32 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/flashrom/+/34551 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jacob Garber jgarber1@ualberta.ca --- M chipset_enable.c 1 file changed, 14 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Jacob Garber: Looks good to me, approved
diff --git a/chipset_enable.c b/chipset_enable.c index 08feda5..8c884a8 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -621,13 +621,13 @@ }; static const struct boot_straps boot_straps_EP80579[] = { { "SPI", BUS_SPI }, - { "reserved" }, - { "reserved" }, + { "reserved", BUS_NONE }, + { "reserved", BUS_NONE }, { "LPC", BUS_LPC | BUS_FWH } }; static const struct boot_straps boot_straps_ich7_nm10[] = - { { "reserved" }, + { { "reserved", BUS_NONE }, { "SPI", BUS_SPI }, - { "PCI" }, + { "PCI", BUS_NONE }, { "LPC", BUS_LPC | BUS_FWH } }; static const struct boot_straps boot_straps_tunnel_creek[] = { { "SPI", BUS_SPI }, @@ -635,29 +635,29 @@ static const struct boot_straps boot_straps_ich8910[] = { { "SPI", BUS_SPI }, { "SPI", BUS_SPI }, - { "PCI" }, + { "PCI", BUS_NONE }, { "LPC", BUS_LPC | BUS_FWH } }; static const struct boot_straps boot_straps_pch567[] = { { "LPC", BUS_LPC | BUS_FWH }, - { "reserved" }, - { "PCI" }, + { "reserved", BUS_NONE }, + { "PCI", BUS_NONE }, { "SPI", BUS_SPI } }; static const struct boot_straps boot_straps_pch89_baytrail[] = { { "LPC", BUS_LPC | BUS_FWH }, - { "reserved" }, - { "reserved" }, + { "reserved", BUS_NONE }, + { "reserved", BUS_NONE }, { "SPI", BUS_SPI } }; static const struct boot_straps boot_straps_pch8_lp[] = { { "SPI", BUS_SPI }, { "LPC", BUS_LPC | BUS_FWH } }; static const struct boot_straps boot_straps_apl[] = { { "SPI", BUS_SPI }, - { "reserved" } }; + { "reserved", BUS_NONE } }; static const struct boot_straps boot_straps_unknown[] = - { { "unknown" }, - { "unknown" }, - { "unknown" }, - { "unknown" } }; + { { "unknown", BUS_NONE }, + { "unknown", BUS_NONE }, + { "unknown", BUS_NONE }, + { "unknown", BUS_NONE } };
const struct boot_straps *boot_straps; switch (ich_generation) {
-
Jacob Garber (Code Review) -
Nico Huber (Code Review)