Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/69995 )
Change subject: cli_classic.c: Be consistent with pointer types ......................................................................
cli_classic.c: Be consistent with pointer types
With `i586-pc-msdosdjgpp-gcc (GCC) 12.2.0`, `uint32_t` is defined as `long unsigned int`, which is not the same as `unsigned int`. As the `flashrom_layout_get_region_range()` function is part of libflashrom API, adjust `cli_classic.c` instead to avoid type mismatches.
Original-Signed-off-by: Angel Pons th3fanbus@gmail.com Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/69451 Original-Reviewed-by: Arthur Heymans arthur@aheymans.xyz Original-Reviewed-by: Evan Benn evanbenn@google.com Original-Reviewed-by: Nikolai Artemiev nartemiev@google.com Original-Tested-by: build bot (Jenkins) no-reply@coreboot.org
Change-Id: Ie8f5bc0d9296f7c6b8f8a351b53052f5fe86b09d Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/flashrom/+/69995 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Anastasia Klimchuk aklm@chromium.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 28 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Anastasia Klimchuk: Looks good to me, but someone else must approve
diff --git a/cli_classic.c b/cli_classic.c index a77422e..4649c73 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -126,7 +126,7 @@ return true; }
-static int parse_wp_range(uint32_t *start, uint32_t *len) +static int parse_wp_range(unsigned int *start, unsigned int *len) { char *endptr = NULL, *token = NULL;
@@ -568,7 +568,7 @@ int namelen, opt, i, j; int startchip = -1, chipcount = 0, option_index = 0; int operation_specified = 0; - uint32_t wp_start = 0, wp_len = 0; + unsigned int wp_start = 0, wp_len = 0; bool force = false, ifd = false, fmap = false; #if CONFIG_PRINT_WIKI == 1 bool list_supported_wiki = false;