Attention is currently required from: Aarya, Carly Zlabek, Vincent Fazio.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79354?usp=email )
Change subject: erasure_layout: Remove redundant verifications from `erase_write`
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS1:
That's a good observation about using `get_flash_region` with potential shorter end range. […]
I am marking this comment as resolved, because taking care of `get_flash_region` situation will be in a separate patch, this patch is independent and does not need to wait.
Patchset:
PS2:
In addition to the testing results posted above, the meson tests completed with no issues.
Looks great! Thank you so much for your work!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79354?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5
Gerrit-Change-Number: 79354
Gerrit-PatchSet: 2
Gerrit-Owner: Carly Zlabek
carlyzlabek@gmail.com
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Vincent Fazio
vfazio@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Carly Zlabek
carlyzlabek@gmail.com
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Vincent Fazio
vfazio@gmail.com
Gerrit-Comment-Date: Thu, 14 Dec 2023 01:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Carly Zlabek
carlyzlabek@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Vincent Fazio
vfazio@gmail.com
Gerrit-MessageType: comment