Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46439 )
Change subject: it87spi.c: return error when probe fails ......................................................................
it87spi.c: return error when probe fails
Make it87spi_probe() return error to match CrOS flashrom.
Signed-off-by: Nikolai Artemiev nartemiev@google.com Change-Id: Ie122c4f954d14c713fb719ec44200b2def00fed6 --- M it87spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/46439/1
diff --git a/it87spi.c b/it87spi.c index e34f5e8..90c6655 100644 --- a/it87spi.c +++ b/it87spi.c @@ -161,7 +161,7 @@ msg_pdbg("No IT87* serial flash segment enabled.\n"); exit_conf_mode_ite(port); /* Nothing to do. */ - return 0; + return 1; } msg_pdbg("Serial flash segment 0x%08x-0x%08x %sabled\n", 0xFFFE0000, 0xFFFFFFFF, (tmp & 1 << 1) ? "en" : "dis");
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46439 )
Change subject: it87spi.c: return error when probe fails ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46439/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46439/1//COMMIT_MSG@9 PS1, Line 9: Make it87spi_probe() return error to match CrOS flashrom. https://chromium-review.googlesource.com/175974
The downstream patch is here and includes a lot more than this change. You may wish to cite it and check if there is anything else like, does the call site expect this change of behavior?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46439 )
Change subject: it87spi.c: return error when probe fails ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/flashrom/+/46439/1/it87spi.c File it87spi.c:
https://review.coreboot.org/c/flashrom/+/46439/1/it87spi.c@164 PS1, Line 164: return 1; Why exactly is this branch considered to be an error? This most likely breaks DualBIOS support.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46439 )
Change subject: it87spi.c: return error when probe fails ......................................................................
Patch Set 1: Code-Review-2
(1 comment)
https://review.coreboot.org/c/flashrom/+/46439/1/it87spi.c File it87spi.c:
https://review.coreboot.org/c/flashrom/+/46439/1/it87spi.c@164 PS1, Line 164: return 1;
Why exactly is this branch considered to be an error? This most likely breaks DualBIOS support.
Thank you for the review Angel.
Nikolai, thanks for raising this with me. Angel and you are correct, this is a specific hack on cros side that needs unwinding. The downstream commit is 5e79c9f6954127319376a8b166e501ccfb1331cd .
Nikolai, just open a bug and assign me it as this overlaps patches I have on cros side that overlaps with this while ripping out the ec alias mechanism into a separate path. I believe we can abandon this patch not to wast upstreams limited time and we can deal with it in the bug.
Nikolai Artemiev has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/46439 )
Change subject: it87spi.c: return error when probe fails ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Nikolai Artemiev (Code Review)