Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Sergii Dmytruk.
Peter Marheine has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email )
Change subject: Extract SPI declarations to the correct header
......................................................................
Patch Set 2:
(2 comments)
File edi.c:
https://review.coreboot.org/c/flashrom/+/85539/comment/107cd861_f79f24d4?usp... :
PS2, Line 18: #include <spi.h>
These are not system includes, so the newly-added lines should still be quoted (`"spi.h"`). That goes for all of these `<spi.h>` occurrences.
File include/spi.h:
https://review.coreboot.org/c/flashrom/+/85539/comment/8e57b371_0609e974?usp... :
PS2, Line 19: #include <flash.h>
Same as for `spi.h`, quote this instead of using angle brackets.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/85539?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0
Gerrit-Change-Number: 85539
Gerrit-PatchSet: 2
Gerrit-Owner: Antonio Vázquez Blanco
antoniovazquezblanco@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: David Reguera Garcia (Dreg)
regueragarciadavid@gmail.com
Gerrit-Reviewer: Matti Finder
matti.finder@gmail.com
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Antonio Vázquez Blanco
antoniovazquezblanco@gmail.com
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: David Reguera Garcia (Dreg)
regueragarciadavid@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Matti Finder
matti.finder@gmail.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Mon, 09 Dec 2024 22:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No