Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68162 )
Change subject: meson: Move programmer test sources into programmer definition
......................................................................
Patch Set 16:
(1 comment)
File tests/meson.build:
https://review.coreboot.org/c/flashrom/+/68162/comment/065b0907_f41e1a68
PS10, Line 32: p_data += {
: 'testsrc' : p_data.get('testsrc', []),
: }
: srcs += p_data.get('testsrc')
See also line 440 in the top-level meson file. It's done the same way there. […]
I just noticed I made a typo and that's why it didn't work. oopsie 😄
Pushed another patch set and moved the lines to the top-level meson.build
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68162
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I307faaf8a9f7ae3c54bd96e7d871a3abb8aadea3
Gerrit-Change-Number: 68162
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 02 Nov 2022 00:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment