Attention is currently required from: David Hendricks, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57580 )
Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
This changes more paths than mentioned in the commit message.
Please just take a deep breath and read the code, sleep over
it and read it again.
Also, there is a conflicting revert going on. We should get
that in first. Reasoning, patching and reviewing with a sane
base is much easier.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8a880251a393666757f3879629a165b7fe3533ef
Gerrit-Change-Number: 57580
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 13 Sep 2021 10:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment