Attention is currently required from: Felix Singer, Angel Pons.
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 )
Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58025/comment/de803a19_d3f7de38
PS2, Line 7: [WIP]
Also, remove this please
Done
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/58025/comment/4ea9ccec_dfc8c854
PS1, Line 403: #define GIGADEVICE_GD25LR256E 0x6719
Please keep the ordering and move it down one more line.
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58025/comment/845e609b_eeaea493
PS2, Line 6452: },
Please use tabs
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58025
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0
Gerrit-Change-Number: 58025
Gerrit-PatchSet: 3
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 22:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment