Change in flashrom[master]: acpi_ec: Implement basic ACPI embedded controller API - flashrom-gerrit

8 Sep 2021


      Attention is currently required from: Nico Huber, Angel Pons, Michael Niewöhner.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 )
Change subject: acpi_ec: Implement basic ACPI embedded controller API
......................................................................
Patch Set 8:
(2 comments)
File acpi_ec.h:
https://review.coreboot.org/c/flashrom/+/55714/comment/140f2c8a_b12f0252 
PS6, Line 20: #if defined(__i386__) || defined(__x86_64__)
...
I know it's still a common pattern, but this shouldn't be here. Such […]
Done
File acpi_ec.c:
https://review.coreboot.org/c/flashrom/+/55714/comment/b68f2e4f_f3f3f568 
PS6, Line 48: 	}
...
+1. […]
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d
Gerrit-Change-Number: 55714
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 08 Sep 2021 17:18:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment