Change in flashrom[master]: pony_spi.c: Extract out get_params to simplify init - flashrom-gerrit

29 Mar 2022


      Attention is currently required from: Edward O'Callaghan, Light.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63130 )
Change subject: pony_spi.c: Extract out get_params to simplify init
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3: 
Thanks! :)
File pony_spi.c:
https://review.coreboot.org/c/flashrom/+/63130/comment/b0fe3489_1357547b 
PS3, Line 167: bool have_device;
This should probably be a separate patch? (changing variable type int -> bool)
https://review.coreboot.org/c/flashrom/+/63130/comment/8492ee3e_70ef320b 
PS3, Line 190: serialport_shutdown
This one line should probably also go to a very useful separate patch.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/63130
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I364febc05c870683cbad114583762b0c006f4bac
Gerrit-Change-Number: 63130
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Light aarya.chaumal@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Light aarya.chaumal@gmail.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 01:07:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment