[XL] Change in flashrom[master]: tree/: Convert flashchip write func ptr to enumerate - flashrom-gerrit

31 Oct 2022


      Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66782 )
Change subject: tree/: Convert flashchip write func ptr to enumerate
......................................................................
Patch Set 13:
(1 comment)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/66782/comment/b56c7441_afcf122a 
PS11, Line 150: static const struct flashchip chip_8MiB = {
...
If you could add one empty line between 149 and 150? Extern declaration is used by more than one str […]
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66782
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I80149de169464b204fb09f1424a86fc645b740fd
Gerrit-Change-Number: 66782
Gerrit-PatchSet: 13
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 31 Oct 2022 22:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment