Attention is currently required from: Matti Finder.
Anastasia Klimchuk has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84934?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: rpmc: add rpmc commands feature ......................................................................
Patch Set 8:
(2 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/84934/comment/17766e77_c4596e19?usp... : PS8, Line 177: get_option('rpmc').allowed() So, I downloaded the patch locally, to try and build it, and discover something.
I got a warning: WARNING: Project specifies a minimum meson_version '>=0.56.0' but uses features which were added in newer versions: * 0.59.0: {'feature_option.allowed()'}
I have locally meson of 1.4.1 so it all builds anyway, and yes it builds, I can see object file for rpmc, good!
BUT we can't have minimum version of 0.56.0 and use a feature of 0.59.0. Maybe we can upgrade the minimum version, but this needs a careful look, and definitely not for this commit.
For this commit I would just replace
get_option('rpmc').allowed()
with
(get_option('rpmc').auto() or get_option('rpmc').enabled())
(can also be nested if, first level checks for libcrypto.found() and inside check for option)
what do you think?
File sfdp.c:
https://review.coreboot.org/c/flashrom/+/84934/comment/3041c0fb_e7fedb4f?usp... : PS6, Line 457: return 0;
I just realized that this doesn't catch the failure if we have no Jedec parameter page at at all. […]
Looks good, thank you!
-
Anastasia Klimchuk (Code Review)