Change in flashrom[master]: Makefile: build shared pci code as part of the programmer - flashrom-gerrit

8 Apr 2022


      Attention is currently required from: Nico Huber, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62835 )
Change subject: Makefile: build shared pci code as part of the programmer
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
...
I'm not convinced about this. […]
This should make it clear, that pcidev.c is part of these programmers and not some global code of flashrom. Same as the usb code from CB:62832. The only difference is the better usage of the shared code.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62835
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I18a54cb0f728a670cc16b67c72e891d26918db19
Gerrit-Change-Number: 62835
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 08 Apr 2022 10:15:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment