Attention is currently required from: Evan Benn.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67720 )
Change subject: writeprotect: Add some debug logging if wp_verify fails
......................................................................
Patch Set 4:
(1 comment)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/67720/comment/5a04019f_4a5b9204
PS1, Line 166: return FLASHROM_WP_ERR_READ_FAILED;
The error code change seems fine.
Please include in the commit message in future.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67720
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5fcaf767570418f90ae44826a1135d9b49653033
Gerrit-Change-Number: 67720
Gerrit-PatchSet: 4
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Evan Benn
evanbenn@google.com
Gerrit-Comment-Date: Mon, 31 Oct 2022 23:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Comment-In-Reply-To: Evan Benn
evanbenn@google.com
Gerrit-MessageType: comment