Change in flashrom[master]: flashchips: add support for GigaDevice GD25WQ80E

[Dino Li (Code Review)]

Dino Li has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/39820 )


Change subject: flashchips: add support for GigaDevice GD25WQ80E
......................................................................

flashchips: add support for GigaDevice GD25WQ80E

Support GD25WQ80E, which is the internal flash of IT81202.

TEST=Building flashrom and flashing FW image into IT81202 successfully.

Change-Id: Ib5feaa6ecc7b11b2218e5f02c087b4331388bef8
Signed-off-by: Dino Li <[e-mail]>
---
M flashchips.c
M flashchips.h
2 files changed, 39 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/39820/1

diff --git a/flashchips.c b/flashchips.c
index 942cbc2..648fed4 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -6787,6 +6787,44 @@
 	},
 
 	{
+		.vendor		= "GigaDevice",
+		.name		= "GD25WQ80E",
+		.bustype	= BUS_SPI,
+		.manufacture_id	= GIGADEVICE_ID,
+		.model_id	= GIGADEVICE_GD25WQ80E,
+		.total_size	= 1024,
+		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
+		.tested		= TEST_OK_PREW,
+		.probe		= probe_spi_rdid,
+		.probe_timing	= TIMING_ZERO,
+		.block_erasers	=
+		{
+			{
+				.eraseblocks = { {4 * 1024, 256} },
+				.block_erase = spi_block_erase_20,
+			}, {
+				.eraseblocks = { {32 * 1024, 32} },
+				.block_erase = spi_block_erase_52,
+			}, {
+				.eraseblocks = { {64 * 1024, 16} },
+				.block_erase = spi_block_erase_d8,
+			}, {
+				.eraseblocks = { {1 * 1024 * 1024, 1} },
+				.block_erase = spi_block_erase_60,
+			}, {
+				.eraseblocks = { {1 * 1024 * 1024, 1} },
+				.block_erase = spi_block_erase_c7,
+			}
+		},
+		.printlock	= spi_prettyprint_status_register_bp4_srwd,
+		.unlock		= spi_disable_blockprotect_bp4_srwd,
+		.write		= spi_chip_write_256,
+		.read		= spi_chip_read,
+		.voltage	= {1650, 3600},
+	},
+
+	{
 		.vendor		= "Hyundai",
 		.name		= "HY29F002B",
 		.bustype	= BUS_PARALLEL,
diff --git a/flashchips.h b/flashchips.h
index 36990e2..dc04a5a 100644
--- a/flashchips.h
+++ b/flashchips.h
@@ -384,6 +384,7 @@
 #define GIGADEVICE_GD25LQ32	0x6016
 #define GIGADEVICE_GD25LQ64	0x6017	/* Same as GD25LQ64B (which is faster) */
 #define GIGADEVICE_GD25LQ128CD	0x6018
+#define GIGADEVICE_GD25WQ80E	0x6514
 #define GIGADEVICE_GD29GL064CAB	0x7E0601
 
 #define HYUNDAI_ID		0xAD	/* Hyundai */

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib5feaa6ecc7b11b2218e5f02c087b4331388bef8
Gerrit-Change-Number: 39820
Gerrit-PatchSet: 1
Gerrit-Owner: Dino Li <[e-mail]>
Gerrit-MessageType: newchange

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39820 )

Change subject: flashchips: add support for GigaDevice GD25WQ80E
......................................................................


Patch Set 1: Code-Review+2

I didn't know that embedded controllers could have internal SPI flash chips. Interesting! 😊


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib5feaa6ecc7b11b2218e5f02c087b4331388bef8
Gerrit-Change-Number: 39820
Gerrit-PatchSet: 1
Gerrit-Owner: Dino Li <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Ting Shen <[e-mail]>
Gerrit-Reviewer: Yilun Lin <[e-mail]>
Gerrit-Reviewer: Yu-Ping Wu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 25 Mar 2020 12:51:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39820 )

Change subject: flashchips: add support for GigaDevice GD25WQ80E
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib5feaa6ecc7b11b2218e5f02c087b4331388bef8
Gerrit-Change-Number: 39820
Gerrit-PatchSet: 1
Gerrit-Owner: Dino Li <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Ting Shen <[e-mail]>
Gerrit-Reviewer: Yilun Lin <[e-mail]>
Gerrit-Reviewer: Yu-Ping Wu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 25 Mar 2020 20:00:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39820 )

Change subject: flashchips: add support for GigaDevice GD25WQ80E
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib5feaa6ecc7b11b2218e5f02c087b4331388bef8
Gerrit-Change-Number: 39820
Gerrit-PatchSet: 1
Gerrit-Owner: Dino Li <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Ting Shen <[e-mail]>
Gerrit-Reviewer: Yilun Lin <[e-mail]>
Gerrit-Reviewer: Yu-Ping Wu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 25 Mar 2020 22:50:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/39820 )

Change subject: flashchips: add support for GigaDevice GD25WQ80E
......................................................................

flashchips: add support for GigaDevice GD25WQ80E

Support GD25WQ80E, which is the internal flash of IT81202.

TEST=Building flashrom and flashing FW image into IT81202 successfully.

Change-Id: Ib5feaa6ecc7b11b2218e5f02c087b4331388bef8
Signed-off-by: Dino Li <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/39820
Tested-by: build bot (Jenkins) <[e-mail]>
Reviewed-by: Angel Pons <[e-mail]>
Reviewed-by: Paul Menzel <[e-mail]>
Reviewed-by: Edward O'Callaghan <[e-mail]>
---
M flashchips.c
M flashchips.h
2 files changed, 39 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  Edward O'Callaghan: Looks good to me, approved



diff --git a/flashchips.c b/flashchips.c
index 942cbc2..648fed4 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -6787,6 +6787,44 @@
 	},
 
 	{
+		.vendor		= "GigaDevice",
+		.name		= "GD25WQ80E",
+		.bustype	= BUS_SPI,
+		.manufacture_id	= GIGADEVICE_ID,
+		.model_id	= GIGADEVICE_GD25WQ80E,
+		.total_size	= 1024,
+		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
+		.tested		= TEST_OK_PREW,
+		.probe		= probe_spi_rdid,
+		.probe_timing	= TIMING_ZERO,
+		.block_erasers	=
+		{
+			{
+				.eraseblocks = { {4 * 1024, 256} },
+				.block_erase = spi_block_erase_20,
+			}, {
+				.eraseblocks = { {32 * 1024, 32} },
+				.block_erase = spi_block_erase_52,
+			}, {
+				.eraseblocks = { {64 * 1024, 16} },
+				.block_erase = spi_block_erase_d8,
+			}, {
+				.eraseblocks = { {1 * 1024 * 1024, 1} },
+				.block_erase = spi_block_erase_60,
+			}, {
+				.eraseblocks = { {1 * 1024 * 1024, 1} },
+				.block_erase = spi_block_erase_c7,
+			}
+		},
+		.printlock	= spi_prettyprint_status_register_bp4_srwd,
+		.unlock		= spi_disable_blockprotect_bp4_srwd,
+		.write		= spi_chip_write_256,
+		.read		= spi_chip_read,
+		.voltage	= {1650, 3600},
+	},
+
+	{
 		.vendor		= "Hyundai",
 		.name		= "HY29F002B",
 		.bustype	= BUS_PARALLEL,
diff --git a/flashchips.h b/flashchips.h
index 36990e2..dc04a5a 100644
--- a/flashchips.h
+++ b/flashchips.h
@@ -384,6 +384,7 @@
 #define GIGADEVICE_GD25LQ32	0x6016
 #define GIGADEVICE_GD25LQ64	0x6017	/* Same as GD25LQ64B (which is faster) */
 #define GIGADEVICE_GD25LQ128CD	0x6018
+#define GIGADEVICE_GD25WQ80E	0x6514
 #define GIGADEVICE_GD29GL064CAB	0x7E0601
 
 #define HYUNDAI_ID		0xAD	/* Hyundai */

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/39820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib5feaa6ecc7b11b2218e5f02c087b4331388bef8
Gerrit-Change-Number: 39820
Gerrit-PatchSet: 2
Gerrit-Owner: Dino Li <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Ting Shen <[e-mail]>
Gerrit-Reviewer: Yilun Lin <[e-mail]>
Gerrit-Reviewer: Yu-Ping Wu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: merged