Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72004 )
Change subject: flashrom_tester: Use Range and usize for all ranges ......................................................................
Patch Set 6:
(2 comments)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/72004/comment/9f65720e_71bfde2d PS5, Line 56: usize
I think `u64` is more appropriate, since we don't really care how this relates to the system's point […]
yes this is where we get into the mess of the flashrom API types. getsize returns a `size_t`. Other parts of the API do other stuff, including `int`, `unsigned int` uint32_t and more :'). usize is big enough on 32 bit platforms to hold flashrom range types, because those dont even get to 32 bits afaict.
The advantage of usize is that I can index into arrays with it without annoying type conversions `buf[range]`. I have deja vu, I think we had this conversation last time round!
https://review.coreboot.org/c/flashrom/+/72004/comment/1d664a3b_e3223234 PS5, Line 56: start,length
It's confusing to describe this as `(start,length)` just because the range itself is using the usual […]
Done
-
Evan Benn (Code Review)