[S] Change in flashrom[main]: buspirate_spi: Add support for hiz output with pullups=off - flashrom-gerrit

1 Dec 2023


      Attention is currently required from: David Reguera Garcia, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79299?usp=email )
Change subject: buspirate_spi: Add support for hiz output with pullups=off
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6: 
David, thank you for the patch! I have a question.
I read the commit message, which is explaining everything really well. It seems like having `pullups=on` and `hiz=on` at the same time is potentially error prone (human error as you said). Maybe we should restrict having these both params on? What could be the use case to have them both on?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/79299?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6d9909b23782ef3fcb1428fd127dae0d6b211855
Gerrit-Change-Number: 79299
Gerrit-PatchSet: 6
Gerrit-Owner: David Reguera Garcia dreg@rootkit.es
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: David Reguera Garcia dreg@rootkit.es
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: David Reguera Garcia dreg@rootkit.es
Gerrit-Comment-Date: Fri, 01 Dec 2023 10:05:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment