Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Light, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62763 )
Change subject: ich_descriptors.c: Initialize structures ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62763/comment/20011bf3_0843bc37 PS7, Line 1364: int ret = read_ich_descriptors_from_dump(dump, len, &cs, &desc);
It could be a false-positive (in a project where tools like scan-build find little […]
Not sure if it actually covers up a bug Nico, more that it would fail predictably in the same manner if there was a bug rather than - happens to have zero in memory this time.
I get what your thinking here but types having default values at instantiation I wouldn't say shadows bugs.
However, one could argue read_ich_descriptors_from_dump() should memset to zero before filling in fields so that the domain of the function is always well defined in desc. Depending on how one wishes to define their conventions of responsibilities.
-
Edward O'Callaghan (Code Review)