Attention is currently required from: Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 )
Change subject: tests: Do not run a test if its driver is not built ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55295/comment/ac13ae7f_dcdb88cb PS5, Line 10: however config options can be disabled and in that case test should : not be run. As we discussed today;
If we can split the tests up to have object files correspond with drivers as a 1:1 map then we can avoid any need to have pre-processor littered everywhere and just have the build system and linker to their respective jobs.
As for the entry-point symbol, to avoid having pre-processor usage there you can provide weak symbols with a default to skip the test.
-
Edward O'Callaghan (Code Review)