Attention is currently required from: Xiang Wang, Stefan Reinauer. Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 )
Change subject: flashrom.c: automatic generated programmer_enum.h ......................................................................
Patch Set 3:
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/49599/comment/40049a83_73f3337d PS3, Line 681: $(shell bash ./util/generator_programmer_enum.sh) Calling bash directly is unnecessary when changing the permissions of util/generator_programmer_enum.sh to 0755.
File util/generator_programmer_enum.sh:
https://review.coreboot.org/c/flashrom/+/49599/comment/673b0b15_6ec0ac85 PS3, Line 1: #! /bin/bash Please locate the bash binary using env: '/usr/bin/env bash'
https://review.coreboot.org/c/coreboot/+/48904
https://review.coreboot.org/c/flashrom/+/49599/comment/632fd344_e9d825fd PS3, Line 22: generator Typo: 'this file is automatically generated by ...'
-
Idwer Vollering (Code Review)