Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64424 )
Change subject: flashchips.c: Drop incorrect `FEATURE_4BA_ENTER_EAR7` uses ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64424/comment/45b092ae_1fe322fd PS1, Line 12: if `FEATURE_4BA_ENTER` is not set. This is true, but I don't see the problem (yet). The flash chip entry describes what the chip can do, not what flashrom can do. It seems possible that a future change or programmer addition could make use of this additional information (for instance, if the dedicated EN4B command can't be executed for whatever reason).
I hope I interpreted this right: The flash chip entry is correct by itself, just together with the code it looks wrong. Is that the case?