Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board

[Lubomir Rintel (Code Review)]

Lubomir Rintel has posted comments on this change. ( https://review.coreboot.org/23338 )

Change subject: digilent_spi: add a driver for the iCEblink40 development board
......................................................................

Patch Set 3:
> Patch Set 2:
>
> (15 comments)
>
> Code looks quite nice :) haven't looked at the protocol yet, though.

Hi. Thanks for the review & the issues you found. I believe I addressed all of them but the first one (the "or later" clause in the GPL header).

I'd indeed prefer the less restrictive use of GPL, however the small part of the driver (the "spispeed" option parsing) was derived from linux_spi.c which seems to be GPLv2 only.

Perhaps that needs to be reworked instead anyway -- the hardware seems to accept only these speeds (in Hz):

62500
125000
250000
500000
1000000
2000000
4000000

The protocol allows setting any speed though, falling back to a slower supported frequency. The first one (62500) isn't even currently settable as the "spispeed" takes a kHz value and 62500 is not a multiply of 1000.