Attention is currently required from: Hsuan-ting Chen, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81792?usp=email )
Change subject: flashchips: Add write-protect support for MX25L12833F ......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81792/comment/2b48494f_9d6a72f4 : PS2, Line 9008: MX25L12833F/MX25L12835F/MX25L12845E/MX25L12865E/MX25L12873F This is multi-chip entry, and two of them MX25L12845E and MX25L12865E has no configuration register. So you can't add the same write-protect support to this entry.
What you can do, and that would be great to do, is to split this large entry into smaller ones, according to their write-protect specs. The chip you are extending MX25L12833F has configuration register and your change would work. Potentially the same can work for MX25L12835F and MX25L12873F, but you need to check datasheets. In any case, MX25L12845E/MX25L12865E need to be extracted into separate entry, because they have no configuration register. Whether the other three can be grouped together or not, depends on the datasheets. Let me know how it goes.