Change in flashrom[master]: [RFC] tests: Abstract port I/O and factor mec1308 specifics out - flashrom-gerrit

29 Apr 2021


      Attention is currently required from: Nico Huber.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52604 )
Change subject: [RFC] tests: Abstract port I/O and factor mec1308 specifics out
......................................................................
Patch Set 1:
(1 comment)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/52604/comment/ef8c6b0f_3a4173bc 
PS1, Line 63: .outb	= mec1308_outb,
...
I'm actually not familiar with our port-i/o using programmer drivers. Without […]
I just wanted to tell you that you are wise person! I am now adding another test with io mocking (for ene_lpc) and yes I need a additional variable in test data struct, a flag which is set in outb and checked/unset in inb.
New test is already working! But I need to make the code look nice and then upload to 51487.
(and then I will split the whole thing into smaller patches, but that's another story).
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia3a424478456a7c968b3c736ba371d755c494f30
Gerrit-Change-Number: 52604
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Thu, 29 Apr 2021 05:26:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment