Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74510 )
Change subject: Makefile: do not generate man page when building sources
......................................................................
Patch Set 1: -Code-Review
(1 comment)
Patchset:
PS1:
I've put CB:74519 up, which builds the man-page if sphinx is available. […]
Yes, this seems like a more proper solution.
Joursoir, I think we need to go ahead with CB:74519 , I hope you are not hurt! I really appreciate you wanted to solve the issue, thank you!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9882445de2a0996f237470a73b6a1eb7eafce808
Gerrit-Change-Number: 74510
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Thu, 20 Apr 2023 11:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment