Attention is currently required from: Anastasia Klimchuk, Matti Finder.
Peter Marheine has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84934?usp=email )
Change subject: rpmc: add rpmc commands feature
......................................................................
Patch Set 2:
(1 comment)
File include/rpmc.h:
https://review.coreboot.org/c/flashrom/+/84934/comment/5b67ddf3_b8ad00be?usp... :
PS1, Line 37: uint8_t status;
Within JESD260 there is a specific 8-bit extended status register defined. […]
I don't mind returning 0x80 on success, but the documentation comments should be clear on how to interpret the return value.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/84934?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38
Gerrit-Change-Number: 84934
Gerrit-PatchSet: 2
Gerrit-Owner: Matti Finder
matti.finder@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Matti Finder
matti.finder@gmail.com
Gerrit-Comment-Date: Thu, 31 Oct 2024 22:36:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matti Finder
matti.finder@gmail.com
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org