Attention is currently required from: Anastasia Klimchuk, Matti Finder.
View Change
1 comment:
File include/rpmc.h:
Patch Set #1, Line 37: uint8_t status;
Within JESD260 there is a specific 8-bit extended status register defined. […]
I don't mind returning 0x80 on success, but the documentation comments should be clear on how to interpret the return value.
To view, visit change 84934. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38
Gerrit-Change-Number: 84934
Gerrit-PatchSet: 2
Gerrit-Owner: Matti Finder <matti.finder@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Matti Finder <matti.finder@gmail.com>
Gerrit-Comment-Date: Thu, 31 Oct 2024 22:36:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matti Finder <matti.finder@gmail.com>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>