Attention is currently required from: Jonathan Zhang. Hello Jonathan Zhang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/57635
to review the following change.
Change subject: Add support for Intel Emmitsburg PCH ......................................................................
Add support for Intel Emmitsburg PCH
This patch does the following: - Add PCIe ID for Intel Emmitsburg PCH - Based on ICH descriptor content, choose CHIPSET_C620_SERIES_LEWISBURG. Although EBG only uses 80 for its PSL value, LBG on Purley and Whitley use 139. So to cover both cases the latter is used.
TESTED=tried on a server with Intel Emmitsburg PCH, flash update was successful. This server, however, does not have flash chip installed, it instead has em100 emulator connected.
Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: David Hendricks ddaveh@amazon.com --- M chipset_enable.c M ich_descriptors.c 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/57635/1
diff --git a/chipset_enable.c b/chipset_enable.c index 638c05f..cb0fbf1 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2073,6 +2073,7 @@ {0x8086, 0xa247, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa248, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa249, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, + {0x8086, 0x1bca, B_S, NT, "Intel", "Emmitsburg Chipset SKU", enable_flash_c620}, {0x8086, 0xa2c4, B_S, NT, "Intel", "H270", enable_flash_pch100}, {0x8086, 0xa2c5, B_S, NT, "Intel", "Z270", enable_flash_pch100}, {0x8086, 0xa2c6, B_S, NT, "Intel", "Q270", enable_flash_pch100}, diff --git a/ich_descriptors.c b/ich_descriptors.c index c3b30a7..652e6e3 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -941,6 +941,9 @@ warn_peculiar_desc(content->ISL != 23, "Gemini Lake"); return CHIPSET_GEMINI_LAKE; } + /* Emmitsburg has 80, Lewisburg on Purley and Whitley has 139 */ + if (content->ISL <= 139) + return CHIPSET_C620_SERIES_LEWISBURG; /* * Ibex Peak is historically used as the default when other * chipsets are not identified.