Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c: Add functions for new erase selction algorithm ......................................................................
Patch Set 87:
(7 comments)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/902bdbb0_628e4869 PS86, Line 114: s
`const`
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/0d758814_8b0f2b3a PS86, Line 130: size_t num;
delete
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/83ce6786_3bd78fad PS86, Line 133: (
`size_t num = 0;`
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/04c23b22_172acdcf PS86, Line 165: const unsigned int
`const size_t`?
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/b7b50688_e86a0048 PS86, Line 166: unsigned int
and this `size_t` too?
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/55295c1b_30c609b2 PS86, Line 216: int
`const int` ?
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/1efdfbb5_7b526c10 PS86, Line 217: int
`const int` ?
Done