29 Apr
2023
29 Apr
'23
9:26 a.m.
Attention is currently required from: Thomas Heijligen, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72657 )
Change subject: meson make: use VERSION file ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/72657/comment/3277f65f_bd4bddc0 PS6, Line 19: flashrom 1.4.0-devel (git:v1.2-1172-g7f186838) It is a bit odd to have 1.4.0 and at the same time v1.2 in the same message? Is it a real example (doesn't seem so...). Let's keep it 1.4 maybe?
--
To view, visit https://review.coreboot.org/c/flashrom/+/72657
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idc17eadb397b3c579bddfbf9ae6bf1b171f5dfb7
Gerrit-Change-Number: 72657
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Peter Marheine pmarheine@chromium.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Sat, 29 Apr 2023 09:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment