David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44308 )
Change subject: flashchips: Add support for Boya Microelectronics BY25Q128AS ......................................................................
Patch Set 4: Code-Review-1
(2 comments)
Looks good to me, other than the Signed-off-by line
https://review.coreboot.org/c/flashrom/+/44308/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/44308/4//COMMIT_MSG@11 PS4, Line 11: Change-Id: I881ba86cfaa82e43c73360135d47c74d896cc191 Add your sign-off (https://flashrom.org/Development_Guidelines#Sign-off_Procedure)
https://review.coreboot.org/c/flashrom/+/44308/4/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/44308/4/flashchips.c@3477 PS4, Line 3477: spi_disable_blockprotect_at25fs040
Yes. […]
Yes, I had suggested that after looking at the datasheet and comparing it with the unlock functions.