Looks good to me, other than the Signed-off-by line

Patch set 4:Code-Review -1

View Change

2 comments:

• Commit Message:

  • Patch Set #4, Line 11: Change-Id: I881ba86cfaa82e43c73360135d47c74d896cc191

    Add your sign-off (https://flashrom.org/Development_Guidelines#Sign-off_Procedure)

• File flashchips.c:

  • Patch Set #4, Line 3477: spi_disable_blockprotect_at25fs040

    Yes. […]

    Yes, I had suggested that after looking at the datasheet and comparing it with the unlock functions.

To view, visit change 44308. To unsubscribe, or for help writing mail filters, visit settings.