Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56414 )
Change subject: dediprog.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 3: Code-Review+1
(4 comments)
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/56414/comment/e8c302fb_e41603bd PS3, Line 221: const int finish, Please indent at least after the opening parenthesis (or only two-tabs total, I think I've seen that as well).
https://review.coreboot.org/c/flashrom/+/56414/comment/961f98b7_bc18c9e1 PS3, Line 222: struct libusb_context *usb_ctx) Usually such context information is made the first parameter.
https://review.coreboot.org/c/flashrom/+/56414/comment/6c22ee53_f55e3a20 PS3, Line 242: size_t size, I don't see a need to waste one line each. For instance, cmd & value & idx and bytes & size could be grouped together.
https://review.coreboot.org/c/flashrom/+/56414/comment/e80cab5f_e721d231 PS3, Line 1025: dp_data->dediprog_devicetype = DEV_UNKNOWN; This shouldn't be necessary anymore as the data is discarded.