Attention is currently required from: Angel Pons, Anastasia Klimchuk.

Patch set 3:Code-Review +1

View Change

4 comments:

• File dediprog.c:

  • Patch Set #3, Line 221: const int finish,

    Please indent at least after the opening parenthesis (or only two-tabs total, I think
    I've seen that as well).

  • Patch Set #3, Line 222: struct libusb_context *usb_ctx)

    Usually such context information is made the first parameter.

  • Patch Set #3, Line 242: size_t size,

    I don't see a need to waste one line each. For instance, cmd & value & idx and
    bytes & size could be grouped together.

  • Patch Set #3, Line 1025: dp_data->dediprog_devicetype = DEV_UNKNOWN;

    This shouldn't be necessary anymore as the data is discarded.

To view, visit change 56414. To unsubscribe, or for help writing mail filters, visit settings.