Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69539 )
Change subject: tests: Redirect to real I/O to support coverage run ......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69539/comment/c3076583_9792b85e PS1, Line 7: Add unmock_io.c
Redirect to real I/O to support coverage run
Done
https://review.coreboot.org/c/flashrom/+/69539/comment/944192b4_69a6e8fc PS1, Line 10: This is to support code coverage.
remove
Done
https://review.coreboot.org/c/flashrom/+/69539/comment/c4dd78db_98d053a8 PS1, Line 8: : Add functions and a struct that defer the io functions mocked by : mock_io to the real implementations.
Implement a check that redirects mock io functions to the real implementations. […]
Done
File tests/unmock_io.c:
https://review.coreboot.org/c/flashrom/+/69539/comment/1cbb1b19_183fa8cb PS1, Line 19: unmock_io
How about `io_real.h` (and `io_real.c`)? this aligns with `io_mock` that we already have. […]
Done
https://review.coreboot.org/c/flashrom/+/69539/comment/33ec8082_af259f59 PS1, Line 25: (void)state;
Just drop this line, none other custom mocks are using it. […]
Done
https://review.coreboot.org/c/flashrom/+/69539/comment/f22a7b33_ed8bc255 PS1, Line 43: // Mock ios that defer to the real io functions. : // These exist so that code coverage can print to real files on disk.
Please format the comment as /* */ and same below
Done
https://review.coreboot.org/c/flashrom/+/69539/comment/b8a490d1_950baab7 PS1, Line 61: maybe_unmock_io
Let's add a comment for this function: […]
the function is documented in the header