Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.

7 comments:

Commit Message:
- Patch Set #1, Line 7: Add unmock_io.c
  Redirect to real I/O to support coverage run
  Done
- Patch Set #1, Line 10: This is to support code coverage.
  remove
  Done
- Patch Set #1, Line 8:
```
Add functions and a struct that defer the io functions mocked by
mock_io to the real implementations.
```
  Implement a check that redirects mock io functions to the real implementations. […]
  Done
File tests/unmock_io.c:
- Patch Set #1, Line 19: unmock_io
  How about `io_real.h` (and `io_real.c`)? this aligns with `io_mock` that we already have. […]
  Done
- Patch Set #1, Line 25: (void)state;
  Just drop this line, none other custom mocks are using it. […]
  Done
- Patch Set #1, Line 43:
```
// Mock ios that defer to the real io functions.
// These exist so that code coverage can print to real files on disk.
```
  Please format the comment as /* */ and same below
  Done
- Patch Set #1, Line 61: maybe_unmock_io
  Let's add a comment for this function: […]
  the function is documented in the header

To view, visit change 69539. To unsubscribe, or for help writing mail filters, visit settings.