Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/63606 )
Change subject: meson: Add optimisation level s and disable debug in meson build ......................................................................
meson: Add optimisation level s and disable debug in meson build
Makefile has optimisation level set explicitly. This patch sets the same level s into meson build.
Also disable debug by default to correspond to make builds.
These two options (optimisation and debug) are linked together in meson build, so they need to be set together to be properly recognised for builds.
Alternative approach would be to use buildtype option (and do not set optimisation and debug). However, none of the standard buildtypes gives a combination that we need: optimisation level s and debug disabled.
TEST=ninja test shows no warnings and tests pass
Change-Id: I4ca96a866529cac320e66516ef280d5100ceefab Signed-off-by: Anastasia Klimchuk aklm@chromium.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/63606 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Thomas Heijligen src@posteo.de --- M meson.build 1 file changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved
diff --git a/meson.build b/meson.build index e9eb4d2..80ccfb3 100644 --- a/meson.build +++ b/meson.build @@ -2,7 +2,11 @@ version : run_command('util/getversion.sh', '--version').stdout().strip(), license : 'GPL-2.0', meson_version : '>=0.50.0', - default_options : ['warning_level=2', 'c_std=c99'], + default_options : [ + 'warning_level=2', + 'c_std=c99', + 'optimization=s', + 'debug=false'], )
# libtool versioning
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.