Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47859 )
Change subject: dummyflasher.c: Allow filling with either 0x00 or 0xff
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/47859/2/dummyflasher.c
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/47859/2/dummyflasher.c@474
PS2, Line 474: free(tmp);
This free was here before. The "emulate" param won't be freed with this change.
Please also move the blank line after the free; it should be attached to the block where tmp was allocated.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I37c6dee932e449201d8bbfb03ca6d139da3cb6a2
Gerrit-Change-Number: 47859
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 09:08:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment